[
https://issues.apache.org/jira/browse/BEAM-9679?focusedWorklogId=448190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448190
]
ASF GitHub Bot logged work on BEAM-9679:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/20 02:52
Start Date: 19/Jun/20 02:52
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #12024:
URL: https://github.com/apache/beam/pull/12024#discussion_r442603782
##########
File path: learning/katas/go/Core Transforms/Side Input/Side
Input/pkg/task/task.go
##########
@@ -0,0 +1,45 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package task
+
+import (
+ "github.com/apache/beam/sdks/go/pkg/beam"
+)
+
+type Person struct {
+ Name, City, Country string
+}
+
+func ApplyTransform(s beam.Scope, personsKV beam.PCollection,
citiesToCountries beam.PCollection) beam.PCollection {
+ citiesToCountriesView := beam.SideInput{
+ Input: citiesToCountries,
+ }
+ return beam.ParDo(s, joinFn, personsKV, citiesToCountriesView)
+}
+
+func joinFn(person Person, citiesToCountriesIter func(*string, *string) bool,
emit func(Person)) {
+ var city, country string
+ for citiesToCountriesIter(&city, &country) {
Review comment:
Good question!
No.
It's a valid way to iterate through KV PCollections as Side inputs. Eg. You
know your set of KVs is short, but dynamic, and you'll need all of them at
random while processing a DoFn.
Ideally we also have an alternate Map/Get style random access to KV side
inputs as well, but it would be in addition to the existing way.
With generics for Go taking their [next
steps](https://blog.golang.org/generics-next-step), maybe next year we could
bolster the iteration API with any official Iteration format, in addition to
the current methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 448190)
Time Spent: 13.5h (was: 13h 20m)
> Core Transforms | Go SDK Code Katas
> -----------------------------------
>
> Key: BEAM-9679
> URL: https://issues.apache.org/jira/browse/BEAM-9679
> Project: Beam
> Issue Type: Sub-task
> Components: katas, sdk-go
> Reporter: Damon Douglas
> Assignee: Damon Douglas
> Priority: P2
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> A kata devoted to core beam transforms patterns after
> [https://github.com/apache/beam/tree/master/learning/katas/java/Core%20Transforms]
> where the take away is an individual's ability to master the following using
> an Apache Beam pipeline using the Golang SDK.
>
> ||Transform||Pull Request||Status||
> |Map|[11564|https://github.com/apache/beam/pull/11564]|Closed|
> |GroupByKey|[11734|https://github.com/apache/beam/pull/11734]|Closed|
> |CoGroupByKey|[11803|https://github.com/apache/beam/pull/11803]|Closed|
> |Combine Simple
> Function|[11866|https://github.com/apache/beam/pull/11866]|Closed|
> |CombineFn|[11883|https://github.com/apache/beam/pull/11883]|Closed|
> |CombinePerKey|[11936|https://github.com/apache/beam/pull/11936]|Closed|
> |Flatten|[11806|https://github.com/apache/beam/pull/11806]|Closed|
> |Partition|[11979|https://github.com/apache/beam/pull/11979]|Closed|
> |Side Input|[12024|https://github.com/apache/beam/pull/12024]|Open|
> |Side Output| | |
> |Branching| | |
> |Composite Transform| | |
> |DoFn Additional Parameters| | |
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
