eolivelli commented on a change in pull request #504: Investigate
CompactionByEntriesTest issue (WIP)
URL: https://github.com/apache/bookkeeper/pull/504#discussion_r137519978
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTest.java
##########
@@ -717,8 +717,6 @@ public void testReadEntryReleaseByteBufs() throws
Exception {
for (Enumeration<LedgerEntry> readEntries = lh.readEntries(0,
numEntries - 1);
readEntries.hasMoreElements();) {
LedgerEntry entry = readEntries.nextElement();
- assertTrue(entry.data.getClass().getName(),
-
entry.data.getClass().getName().contains("PooledNonRetainedSlicedByteBuf"));
Review comment:
why are you removing this checks ? they are 'poor man' checks about the fact
that we are pooling/non-pooling the ByteBuf. it is important to check that in
v2 protocol bytebufs are "pooled"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
