zhaijack commented on a change in pull request #500: Issue 499: make a package
contains all the jar
URL: https://github.com/apache/bookkeeper/pull/500#discussion_r137528706
##########
File path: bookkeeper-server/pom.xml
##########
@@ -283,7 +283,7 @@
</plugin>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
- <version>2.2.1</version>
+ <version>${maven-assembly-plugin.version}</version>
Review comment:
Thanks @eolivelli . I thought it would be better to be similar to DL. in DL
there are 2 binary provided, one is -all, while the other is like our
bookkeeper-server-bin. By this way, user will choose which is better for their
use case.
I am OK with both way: drop assemble for bookkeeper-server or not.
@sijie what do you think of it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
