zhaijack commented on a change in pull request #509: Issue 508: Introduce
lifecycle components for managing components in bookie server
URL: https://github.com/apache/bookkeeper/pull/509#discussion_r139260652
##########
File path: bookkeeper-server/pom.xml
##########
@@ -30,16 +30,11 @@
</properties>
<dependencies>
<dependency>
- <groupId>org.apache.bookkeeper.stats</groupId>
- <artifactId>bookkeeper-stats-api</artifactId>
+ <groupId>org.apache.bookkeeper</groupId>
+ <artifactId>bookkeeper-common</artifactId>
<version>${project.parent.version}</version>
</dependency>
<dependency>
- <groupId>com.google.guava</groupId>
Review comment:
this is a good catch. shading is a big pain. I would defer this to a later
task, because we might need to shade the classes that use guava.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
