ivankelly commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140175977
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java
##########
@@ -200,4 +214,181 @@ private void createComplete(int rc, LedgerHandle lh) {
cb.createComplete(rc, lh, ctx);
}
+ // Builder interface methods
+
+ private static final byte[] EMPTY_PASSWORD = new byte[0];
Review comment:
I wouldn't worry too much about GC when it comes to these builders. The
builders will only be constructed for open/close/create etc, which are
relatively rare operations. Furthermore, builders will only live for an
instant, so will likely be collected before leaving eden. The Op themselves
involve RPC so could easily live long enough to see survivor. Moving the
builder out of op therefore makes sense (and also allows the op's members to be
final).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
