eolivelli commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140177666
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java
##########
@@ -200,4 +214,181 @@ private void createComplete(int rc, LedgerHandle lh) {
cb.createComplete(rc, lh, ctx);
}
+ // Builder interface methods
+
+ private static final byte[] EMPTY_PASSWORD = new byte[0];
Review comment:
after @sijie and @ivankelly comments
I prefer to create standalone builders which in turn will use the *Ops
Tests will be simpler and we will be able to introduce Netty recycler in a
second run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
