jvrao commented on a change in pull request #145: BOOKKEEPER-1057: Do not log
error message after read failure in PendingReadOp
URL: https://github.com/apache/bookkeeper/pull/145#discussion_r140643455
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
##########
@@ -389,8 +389,10 @@ private void submitCallback(int code) {
break;
}
}
- LOG.error("Read of ledger entry failed: L{} E{}-E{}, Heard from
{}. First unread entry is {}",
- new Object[] { lh.getId(), startEntryId, endEntryId,
heardFromHosts, firstUnread });
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Read of ledger entry failed: L{} E{}-E{}, Heard
from {}. First unread entry is {}",
+ new Object[] { lh.getId(), startEntryId, endEntryId,
heardFromHosts, firstUnread });
+ }
Review comment:
Any rational why we are converting a read error into a debug message?
Read errors are very important to track.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
