jvrao commented on a change in pull request #80: BOOKKEEPER-816: use native
fallocate to improve journal allocation
URL: https://github.com/apache/bookkeeper/pull/80#discussion_r140645369
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java
##########
@@ -162,11 +192,12 @@ private JournalChannel(File journalDirectory, long logId,
fc.write(bb);
bc = new BufferedChannel(fc, writeBufferSize);
- forceWrite(true);
- nextPrealloc = this.preAllocSize;
- fc.write(zeros, nextPrealloc - journalAlignSize);
+
+ // sync the file
+ // syncRangeOrForceWrite(0, HEADER_SIZE);
Review comment:
Comments without code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
