eolivelli commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140970651
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -584,7 +591,11 @@ LedgerIdGenerator getLedgerIdGenerator() {
* report fake bytes with a mathching MAC unless it knows the password
*/
public enum DigestType {
- MAC, CRC32
+ MAC, CRC32;
+
+ public static DigestType
fromApiDigestType(org.apache.bookkeeper.client.api.DigestType digestType) {
Review comment:
we want new clients not to use (now) legacy org.apache.bookkeeper.client
package so we need new enums and classes, using the same name in this case is
ok as we are using different packages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
