zhaijack commented on a change in pull request #521: Issue 520: Add more http endpoint URL: https://github.com/apache/bookkeeper/pull/521#discussion_r141219951
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/http/LostBookieRecoveryDelayService.java ########## @@ -0,0 +1,107 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ +package org.apache.bookkeeper.http; + +import com.google.common.base.Preconditions; +import java.util.HashMap; +import org.apache.bookkeeper.client.BookKeeperAdmin; +import org.apache.bookkeeper.conf.ClientConfiguration; +import org.apache.bookkeeper.conf.ServerConfiguration; +import org.apache.bookkeeper.http.service.HttpService; +import org.apache.bookkeeper.http.service.HttpServiceRequest; +import org.apache.bookkeeper.http.service.HttpServiceResponse; +import org.apache.bookkeeper.util.JsonUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * HttpService that handle Bookkeeper Configuration related http request. + */ +public class LostBookieRecoveryDelayService implements HttpService { + + static final Logger LOG = LoggerFactory.getLogger(LostBookieRecoveryDelayService.class); + + protected ServerConfiguration conf; + + public LostBookieRecoveryDelayService(ServerConfiguration conf) { + Preconditions.checkNotNull(conf); + this.conf = conf; + } + + /* + * set/get lostBookieRecoveryDelay. + */ + @Override + public HttpServiceResponse handle(HttpServiceRequest request) throws Exception { + HttpServiceResponse response = new HttpServiceResponse(); + + ClientConfiguration adminConf = new ClientConfiguration(conf); + BookKeeperAdmin admin = new BookKeeperAdmin(adminConf); + + if (HttpServer.Method.PUT == request.getMethod() || HttpServer.Method.POST == request.getMethod()) { + // request body as {"delay_seconds": <delay_seconds>} + String requestBody = request.getBody(); + + if (requestBody == null) { + admin.close(); + response.setCode(HttpServer.StatusCode.NOT_FOUND); + response.setBody("Null request body for lostBookieRecoveryDelay."); + return response; + } + + @SuppressWarnings("unchecked") + HashMap<String, Integer> configMap = JsonUtil.fromJson(requestBody, HashMap.class); + if (configMap != null && configMap.containsKey("delay_seconds")) { + int delaySeconds = configMap.get("delay_seconds"); + admin.setLostBookieRecoveryDelay(delaySeconds); + admin.close(); + response.setCode(HttpServer.StatusCode.OK); + response.setBody("Success set lostBookieRecoveryDelay to " + delaySeconds); + return response; + } else { + admin.close(); + response.setCode(HttpServer.StatusCode.NOT_FOUND); + response.setBody("Request body not contains lostBookieRecoveryDelay."); + return response; + } + } else if (HttpServer.Method.GET == request.getMethod()) { + try { + int delaySeconds = admin.getLostBookieRecoveryDelay(); + admin.close(); + response.setCode(HttpServer.StatusCode.OK); + response.setBody("lostBookieRecoveryDelay value: " + delaySeconds); + LOG.debug("response body:" + response.getBody()); + return response; + } catch (Exception e) { + // may get noNode exception + e.printStackTrace(); Review comment: Thanks will change it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
