ivankelly commented on a change in pull request #521: Issue 520: Add more http 
endpoint
URL: https://github.com/apache/bookkeeper/pull/521#discussion_r141302775
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/http/BKHttpServiceProvider.java
 ##########
 @@ -196,7 +196,11 @@ public HttpService provideReadLedgerEntryService() {
      */
     @Override
     public HttpService provideListBookieInfoService() {
 
 Review comment:
   There's an inconsistency in the scope of the data returned from this two 
endpoints. Bookie info returns the bookie info for the whole cluster, while 
list disk files returns the files for only one node.
   
   I would suggest putting bookie info under /api/v1/bookkeeper/
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to