eolivelli commented on a change in pull request #526: ISSUE 525 Refactor
PerChannelBookieClient [WIP]
URL: https://github.com/apache/bookkeeper/pull/526#discussion_r141809703
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -654,42 +624,28 @@ public void readEntryAndFenceLedger(final long ledgerId,
byte[] masterKey,
}
final CompletionKey completionKey = completion;
- if (completionObjects.putIfAbsent(completionKey, new
ReadCompletion(this, readEntryOpLogger, cb,
- ctx, ledgerId, entryId, scheduleTimeout(completionKey,
readEntryTimeout))) != null) {
+ if (completionObjects.putIfAbsent(
Review comment:
@ivankelly
you are right, we need to capture the context so there is no way of not
allocating a new object
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
