sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142204792
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -628,6 +690,22 @@ public long addEntry(byte[] data) throws
InterruptedException, BKException {
return addEntry(data, 0, data.length);
}
+ @Override
+ public CompletableFuture<Long> append(ByteBuffer data) {
Review comment:
@reddycharan the way to think about this - `client.api` will be new api,
`BookKeeper` class will become the implementation class. the old methods in
`BookKeeper` will be deprecated at 4.7.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
