sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142194465
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -1415,4 +1375,48 @@ static EventLoopGroup getDefaultEventLoopGroup() {
return new NioEventLoopGroup(numThreads, threadFactory);
}
}
+
+ @Override
+ public CreateBuilder newCreateLedgerOp() {
+ return new LedgerCreateOp.CreateBuilderImpl(this);
+ }
+
+ @Override
+ public OpenBuilder newOpenLedgerOp() {
+ return new LedgerOpenOp.OpenBuilderImpl(this);
+ }
+
+ @Override
+ public DeleteBuilder newDeleteLedgerOp() {
+ return new LedgerDeleteOp.DeleteBuilderImpl(this);
+ }
+
+ ReentrantReadWriteLock getCloseLock() {
Review comment:
from line 1394 to 1418, they should be moved to around line 590, where we
put all the getter functions.
also if they are used for testing only, please mark them as
@VisibleForTesting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
