sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142483523
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -114,7 +120,7 @@
final BookieClient bookieClient;
final BookieWatcher bookieWatcher;
- final OrderedSafeExecutor mainWorkerPool;
+ final private OrderedSafeExecutor mainWorkerPool;
Review comment:
private should before final.
but why do you want to add `private` for now? can we do this in a separate
change? because all other variables are just package private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
