sijie commented on a change in pull request #510: Issue-605 BP-15 New CreateLedger API URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142491918
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntry.java ########## @@ -0,0 +1,87 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ +package org.apache.bookkeeper.client.api; + +import io.netty.buffer.ByteBuf; +import java.io.InputStream; +import org.apache.bookkeeper.conf.ClientConfiguration; + +/** + * An entry. + * + * @since 4.6 + */ +public interface LedgerEntry { + + /** + * The id of the ledger which contains the entry. + * + * @return the id of the ledger + */ + long getLedgerId(); + + /** + * The id of the entry. + * + * @return the id of the entry + */ + long getEntryId(); + + /** + * The length of the entry, that is the size of the content expressed in bytes. + * + * @return the size of the content + */ + long getLength(); + + /** + * Returns the content of the entry. This method can be called only once. While using v2 wire protocol this method + * will automatically release the internal ByteBuf. + * + * @return the content of the entry + * @throws IllegalStateException if this method is called twice + */ + byte[] getEntry(); + + /** + * Returns the content of the entry. This method can be called only once. While using v2 wire protocol this method + * will automatically release the internal ByteBuf when calling the close method of the returned InputStream. + * + * @return an InputStream which gives access to the content of the entry + * @throws IllegalStateException if this method is called twice + */ + InputStream getEntryInputStream(); Review comment: I would suggest removing `getEntry` and `getEntryInputStream` from the new api. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
