sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142488503
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
##########
@@ -158,6 +159,18 @@ public void asyncAddEntry(final long entryId, final
byte[] data, final int offse
doAsyncAddEntry(op, Unpooled.wrappedBuffer(data, offset, length), cb,
ctx);
}
+ private void asyncAddEntry(final long entryId, final ByteBuf data, final
AddCallback cb, final Object ctx) {
Review comment:
I am a bit confused on this function. it should exist before this change
right? what do you add this function here again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
