sijie commented on a change in pull request #510: Issue-605 BP-15 New 
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142606658
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeper.java
 ##########
 @@ -66,10 +65,9 @@ static BookKeeperBuilder newBuilder(final 
ClientConfiguration clientConfiguratio
     /**
      * Close the client and release every resource.
      *
-     * @throws BKException
      * @throws InterruptedException
      */
     @Override
-    void close() throws BKException, InterruptedException;
 
 Review comment:
   if you already introduce the new exception class in api package, you don't 
need to drop this signature, no?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to