sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142604191
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java
##########
@@ -83,12 +84,12 @@
@Override
@SuppressWarnings(value = "unchecked")
public void createComplete(int rc, LedgerHandle lh, Object ctx) {
- SyncCallbackUtils.finish(rc, lh, this);
+ SyncCallbackUtils.finish(rc, lh, (CompletableFuture<LedgerHandle>)
this);
Review comment:
hmm... this is a bit tricky. you are casting a CompletableFuture<T> to
CompletableFuture<LedgerHandle>. did you take a look the approach I suggested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
