sijie commented on a change in pull request #510: Issue-605 BP-15 New CreateLedger API URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142607731
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/impl/BookKeeperBuilder.java ########## @@ -18,10 +18,13 @@ * under the License. * */ -package org.apache.bookkeeper.client.api; +package org.apache.bookkeeper.client.impl; Review comment: hmm. I wasn't suggesting moving interface to impl package. I was suggesting moving BookKeeperBuilderImpl to impl package. the BookKeeperBuilder interface should still in `api` package. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
