sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r142608475
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
##########
@@ -241,7 +229,15 @@ public void safeRun() {
@Override
public CompletableFuture<Long> write(long entryId, ByteBuf data) {
SyncAddCallback callback = new SyncAddCallback();
- asyncAddEntry(entryId, data, callback, null);
+ PendingAddOp op = new PendingAddOp(this, callback, null);
Review comment:
hmm... you just moved the logic back to write function... I still don't
understand why do you need to duplicate the logic in `asyncAddEntry`. the new
`write(long entryId, ByteBuf data)` should be just a shortcut of the legacy
`asyncAddEntry` method, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
