eolivelli commented on issue #510: Issue-605 BP-15 New CreateLedger API URL: https://github.com/apache/bookkeeper/pull/510#issuecomment-334352160 @sijie I am ready. I have addressed all of your comments. I would like not to expose the ability to set the ZooKeeper object in the BookKeeperBuilder, I prefer passing a ZKClientConfig. Our ZK client handles retries automatically but it is not configurable. For this patch I would like not to include the ZooKeeper object in BookKeeperBuilder interface, I will create a followup issue for ZKClientConfig ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
