sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r143026489
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -628,6 +686,16 @@ public long addEntry(byte[] data) throws
InterruptedException, BKException {
return addEntry(data, 0, data.length);
}
+ @Override
+ public CompletableFuture<Long> append(ByteBuf data) {
Review comment:
can you just call `#asyncAddEntry(data, callback, ctx)`? logic such as
retain bytebuf and construct pending add op is already handled by
`#asyncAddEntry`. you don't need to duplicate this logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
