sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r143025513
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -312,17 +318,24 @@ void writeLedgerConfig(GenericCallback<Void> writeCb) {
/**
* Close this ledger synchronously.
+ *
+ * @throws java.lang.InterruptedException
+ * @throws org.apache.bookkeeper.client.BKException
* @see #asyncClose
*/
+ @Override
public void close()
Review comment:
do you need this? Handle already have a default implementation of `#close`
using `#asyncClose`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
