sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r143031590
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
##########
@@ -225,6 +226,21 @@ public void safeRun() {
}
}
+ @Override
+ public CompletableFuture<Long> write(long entryId, ByteBuf data) {
Review comment:
can we try to add one? I like to make sure all these method share same code
path, rather than duplicating. otherwise it is going to be hard to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
