ivankelly commented on a change in pull request #521: Issue 520: Add more http
endpoint
URL: https://github.com/apache/bookkeeper/pull/521#discussion_r143708903
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/http/BKHttpServiceProvider.java
##########
@@ -64,6 +68,9 @@ private BKHttpServiceProvider(BookieServer bookieServer,
ClientConfiguration clientConfiguration = new
ClientConfiguration(serverConf)
.setZkServers(serverConf.getZkServers());
this.bka = new BookKeeperAdmin(clientConfiguration);
+
+ this.executor = Executors.newSingleThreadExecutor(
+ new
ThreadFactoryBuilder().setNameFormat("BKHttpServiceThread").build());
Review comment:
thread factory should only create daemon threads, otherwise the thread may
hold the process open during shutdown. You should also shutdown the executor if
possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
