ivankelly commented on a change in pull request #521: Issue 520: Add more http 
endpoint
URL: https://github.com/apache/bookkeeper/pull/521#discussion_r143709565
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/http/DecommissionService.java
 ##########
 @@ -82,14 +86,13 @@ public void run() {
                                 LOG.error("Error handling decommissionBookie: 
{} with exception {}", bookieSrc, e);
 
 Review comment:
   It would be good to have logging before and after the call to 
decommissionBookie, so that an admin can see whether the process started and 
ended if anything goes wrong.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to