sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145531204
########## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ########## @@ -73,6 +74,14 @@ message BKPacketHeader { required uint64 txnId = 3; } +/** + * Type of Ledger + */ +enum LedgerType { Review comment: I saw `LedgerType` is defined in both `BookkeeperProtocol` and `DataFormats`. Can we define it in a common place? otherwise, it is going to be hard to maintain. one thought, if `LedgerType` is associated with metadata, it should exist in `DataFormats`; and `BookkeeperProtocol` references it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services