sijie commented on a change in pull request #643: BP-14 part 2 - client side
changes
URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145544706
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
##########
@@ -224,15 +225,47 @@ private void completeAdd(final int rc,
executor.submitOrdered(ledgerId, new SafeRunnable() {
@Override
public void safeRun() {
- cb.writeComplete(rc, ledgerId, entryId, addr, ctx);
+ // TODO: lastAddSyncedEntry, see next commits
Review comment:
avoid `see next commits`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
