eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata
and protocol changes
URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145631534
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -960,7 +961,8 @@ public void asyncCreateLedgerAdv(final int ensSize, final
int writeQuorumSize, f
return;
}
new LedgerCreateOp(BookKeeper.this, ensSize, writeQuorumSize,
- ackQuorumSize, digestType, passwd, cb, ctx,
customMetadata).initiateAdv((long)(-1));
+ ackQuorumSize, digestType, passwd, cb, ctx,
customMetadata, LedgerType.PD_JOURNAL)
+ .initiateAdv((long)(-1));
Review comment:
ok, but this is not really part of this change. I would like not to review
all the usages of -1 and find which -1 are used for INVALID_LEDGER_ID
This line has been changed only in order to add LedgerType.PD_JOURNAL
I will change to -1L
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
