sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto
replication should honor ensemble placement policy
URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146350639
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
##########
@@ -626,25 +577,21 @@ public void processResult(int rc, String path, Object
ctx, List<String> children
* determine if any of the ledger fragments for it were stored at the dead
* input bookie.
*
- * @param bookieSrc
- * Source bookie that had a failure. We want to replicate the
+ * @param bookiesSrc
+ * Source bookies that had a failure. We want to replicate the
* ledger fragments that were stored there.
- * @param bookieDest
- * Optional destination bookie that if passed, we will copy all
- * of the ledger fragments from the source bookie over to it.
+ * @param dryrun
+ * dryrun the recover procedure.
+ * @param skipOpenLedgers
+ * Skip recovering open ledgers.
* @param cb
* RecoverCallback to invoke once all of the data on the dead
* bookie has been recovered and replicated.
* @param context
* Context for the RecoverCallback to call.
- * @param availableBookies
- * List of Bookie Servers that are available to use for
- * replicating data on the failed bookie. This could contain a
- * single bookie server if the user explicitly chose a bookie
- * server to replicate data to.
*/
- private void getActiveLedgers(final BookieSocketAddress bookieSrc, final
BookieSocketAddress bookieDest,
- final RecoverCallback cb, final Object context, final
List<BookieSocketAddress> availableBookies) {
+ private void getActiveLedgers(final Set<BookieSocketAddress> bookiesSrc,
final boolean dryrun,
+ final boolean skipOpenLedgers, final
RecoverCallback cb, final Object context) {
// Wrapper class around the RecoverCallback so it can be used
// as the final VoidCallback to process ledgers
class RecoverCallbackWrapper implements AsyncCallback.VoidCallback {
Review comment:
created: https://github.com/apache/bookkeeper/issues/655
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
