eolivelli commented on a change in pull request #649: Pool AddCompletions
URL: https://github.com/apache/bookkeeper/pull/649#discussion_r146470714
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -832,28 +836,7 @@ private void writeAndFlush(final Channel channel,
}
try{
- channel.writeAndFlush(request)
- .addListener(new ChannelFutureListener() {
- @Override
- public void operationComplete(ChannelFuture future)
- throws Exception {
- if (future.isSuccess()) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Successfully wrote request {}
to {}",
- requestToString(request),
- channel.remoteAddress());
- }
- } else {
- if (!(future.cause()
- instanceof ClosedChannelException)) {
- LOG.warn("Writing request {} to {} failed
: ",
- requestToString(request),
- channel, future.cause());
- }
- errorOut(key);
Review comment:
@ivankelly do we have some sort of test case about this case ?
Anyway your explanation is very clear to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
