eolivelli commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146650203
########## File path: bookkeeper-server/pom.xml ########## @@ -178,6 +178,11 @@ <artifactId>http-server</artifactId> <version>${project.version}</version> </dependency> + <dependency> + <groupId>com.carrotsearch</groupId> Review comment: Do you have checked license for this? Is it really needed? We already have several custom collections, maybe we could have our own implementation of IntArrayList without importing a whole third party lib. This will be used on client side. It is used in EnsemblePlacement policy which is very often customized, at least in my projects. I would not like to impose such dep on public plugins API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services