sijie commented on a change in pull request #657: Use hash set with native ints
for write set tracking
URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146698783
##########
File path: bookkeeper-server/pom.xml
##########
@@ -178,6 +178,11 @@
<artifactId>http-server</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.carrotsearch</groupId>
Review comment:
second to this comment here:
- for license, we need to update src/main/resources/NOTICE.bin.txt
- it is a new dependency introduced on client. It would prefer if we can
avoid using this dependency.
- I am not sure what would be the benefits of using IntArrayList. If boxing,
unboxing Integer and using an ArrayList is a problem, why can't we use `int[]`
because we don't need resizing ability? we can wrap `int[]` into a recycle
class, it should be simple and efficient, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
