ivankelly commented on a change in pull request #720: Fixed simultaneus reads
on same ledger/entry with v2 protocol
URL: https://github.com/apache/bookkeeper/pull/720#discussion_r150481321
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -845,6 +846,56 @@ private void writeAndFlush(final Channel channel,
errorOut(key);
}
}
+
+ void errorOutReadKey(final CompletionKey key) {
Review comment:
This code isn't valid anymore. Erroring out is now part of the
completionValue, so this should be handled there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
