zhaijack commented on a change in pull request #729: Issue 550: add
readLastAddConfirmedAndEntry in ReadHandle for long poll read
URL: https://github.com/apache/bookkeeper/pull/729#discussion_r151311751
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/ReadHandle.java
##########
@@ -111,4 +112,32 @@
*/
long getLength();
+ /**
+ * The type contains LAC and a LedgerEntry want to read.
+ * It is used for readLastAddConfirmedAndEntry.
+ */
+ @Data
+ class LastConfirmedAndEntry {
+ private final Long lac;
+ private final LedgerEntry entry;
+ }
+
+ /**
+ * Asynchronous read specific entry and the latest last add confirmed.
+ * If the next entryId is less than known last add confirmed, the call
will read next entry directly.
+ * If the next entryId is ahead of known last add confirmed, the call will
issue a long poll read
+ * to wait for the next entry <i>entryId</i>.
+ *
+ * @param entryId
+ * next entry id to read
+ * @param timeOutInMillis
Review comment:
Yes. In LedgerHandle, most of the similar situation will return null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
