eolivelli commented on a change in pull request #729: Issue 550: add
readLastAddConfirmedAndEntry in ReadHandle for long poll read
URL: https://github.com/apache/bookkeeper/pull/729#discussion_r151800065
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/BookKeeperApiTest.java
##########
@@ -203,6 +203,12 @@ public void testOpenLedgerRead() throws Exception {
assertEquals(2,
result(reader.tryReadLastAddConfirmed()).intValue());
checkEntries(result(reader.read(0, reader.getLastAddConfirmed())),
data);
checkEntries(result(reader.readUnconfirmed(0,
reader.getLastAddConfirmed())), data);
+
+ // test readLastAddConfirmedAndEntry
+ LastConfirmedAndEntry lastConfirmedAndEntry =
+ result(reader.readLastAddConfirmedAndEntry(0, 999, false));
Review comment:
We have a 999 timeout less then 1 second. This test could be flaky.
Maybe we can do a loop until the condition is verified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
