sijie commented on a change in pull request #742: Issue-744 BP-18 introduce
write flags
URL: https://github.com/apache/bookkeeper/pull/742#discussion_r151910336
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java
##########
@@ -20,14 +20,22 @@
*/
package org.apache.bookkeeper.client.api;
-import com.google.common.base.Preconditions;
+import static com.google.common.base.Preconditions.checkArgument;
+
import java.util.EnumSet;
+import lombok.Getter;
/**
* Flags to specify the behaviour of writes
*/
+@Getter
public enum WriteFlag {
- DEFERRED_FORCE(1);
+
+ /**
+ * Writes will be ackknowledged by the server even if the entry
Review comment:
typo - acknowledged
I would suggest changing the comment to "acknowledged after writing to
filesystem but not yet been persisted to disks" or something like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
