sijie commented on a change in pull request #754: Issue #753: Allow option to 
disable data sync on journal
URL: https://github.com/apache/bookkeeper/pull/754#discussion_r152491411
 
 

 ##########
 File path: bookkeeper-server/conf/bk_server.conf
 ##########
 @@ -296,6 +296,10 @@ journalDirectory=/tmp/bk-txn
 # Should we remove pages from page cache after force write
 # journalRemoveFromPageCache=false
 
+# Should the data be fsynced on journal before acknowledgment
 
 Review comment:
   fyi, I created an issue #756 (we need some guidelines on providing 
guidelines for a feature introduced in a release).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to