ivankelly commented on a change in pull request #727: Issue 693: add interface
and implementation of LedgerEntries
URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152543344
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java
##########
@@ -35,10 +35,15 @@
LedgerEntry getEntry(long entryId);
/**
- * In this, It does not retain the ByteBuf references for the entries in
this LedgerEntries.
+ * In this method, It does not increment the reference counts of ByteBuf
for the entries in this LedgerEntries.
* The caller who calls {@link #iterator()} should be careful for not
releasing the references.
*
- * @return the iterator of type LedgerEntry
+ * when iterator is called, you are handing out the entries, you may not
know when the caller will
Review comment:
I don't think this is correct. You're not handing out the entries. You are
handing out an iterator which will iterate over the set of entries held by the
LedgerEntries. I don't think refcounting should come into the iterator part of
it at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
