sijie commented on a change in pull request #755: Issue 750: support ByteBuf,
ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle
URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152639133
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/impl/LedgerEntryImpl.java
##########
@@ -85,6 +86,7 @@ public void setLength(long length) {
}
public void setEntryBuf(ByteBuf buf) {
+ ReferenceCountUtil.release(entryBuf);
Review comment:
yes it is null safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
