ivankelly commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-346889156 Failing on findbugs :/ Will fix up if i get a chance later. The difference with the new implementation and the old readBookiesBlocking, is that this one waits for the listeners to run. readBookiesBlocking would do a blocking read of the bookies, but this would not populate the RackAwarePlacementPolicyImpl, which is was only populated by the listener. The listener would trigger a few moments later on a different thread, but by that time the test had progressed and possibly failed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services