eolivelli commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347183565 I think that the core of BK is fencing/recovery + LAC, they are pretty unique and amazing features. When you are using BK you know what you are doing, you use BK as a building block for complex distributed systems, so I think that this default is not so important. From a newbie perspective I think that recovery should be disabled by default, it is odd that you are opening for "read" a stream and you break the writer. I think that old users that are switching to the new API already know openLedger vs openLedgerNoRecovery and they will read carefully the docs and they have tests cases which will break if fencing is not working as they expected, so the migration is not a real deal for me. **Overall I prefer recovery = false by default.** If you are scared of this, we could require the client to always declare the intent without any default. For instance ``` withRole(Role.READER) ``` -> recovery = NO and ``` withRole(Role.RECOVERER) ``` -> recovery = YES
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
