reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153376624
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java ########## @@ -78,47 +76,43 @@ public SyncThread(ServerConfiguration conf, .setNameFormat("SyncThread-" + conf.getBookiePort() + "-%d"); this.executor = Executors.newSingleThreadScheduledExecutor(tfb.build()); flushInterval = conf.getFlushInterval(); Review comment: this 'flushInterval' conf is not used anywhere anymore. This conf can be removed and correspondingly all its callers in testcases. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services