sijie commented on a change in pull request #775: Tests wait for client to see
started bookie
URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153588504
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java
##########
@@ -601,24 +592,18 @@ protected Bookie newBookie(ServerConfiguration conf) {
return b;
}
};
- server.start();
+ BookieSocketAddress address = Bookie.getBookieAddress(conf);
if (bkc == null) {
bkc = new BookKeeperTestClient(baseClientConf);
}
+ Future<?> waitForBookie = bkc.waitForBookie(address);
- int port = conf.getBookiePort();
- String host = InetAddress.getLocalHost().getHostAddress();
- if (conf.getUseHostNameAsBookieID()) {
- host = InetAddress.getLocalHost().getCanonicalHostName();
- }
- while (bkc.getZkHandle().exists(
Review comment:
same here. this changes the semantic. the original one is "wait for a bookie
to appear in writable set". this changes to "wait for a bookie to appear to be
in either writableset or readonlyset".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
