philipsu522 commented on a change in pull request #776: Issue 709: Add Slow
Bookkeeper Servers to Placement Policy for read ordering
URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153612490
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
##########
@@ -92,11 +92,17 @@
this.ensemble = ensemble;
if (lh.bk.isReorderReadSequence()) {
+ DistributionSchedule.WriteSet unorderedWriteSet =
lh.getDistributionSchedule().getWriteSet(entryId);
+ BookKeeperServerHealthInfo bookKeeperServerHealthInfo =
generateHealthInfoForWriteSet(
+ unorderedWriteSet,
+ ensemble,
+ lh
+ );
writeSet = lh.bk.getPlacementPolicy()
.reorderReadSequence(
ensemble,
- lh.bookieFailureHistory.asMap(),
- lh.distributionSchedule.getWriteSet(eId));
+ bookKeeperServerHealthInfo,
+ lh.distributionSchedule.getWriteSet(eid));
Review comment:
Actually looks like the LedgerEntry interface was changed in a recent commit
- I'll need a bit more time to incorporate that change. Will submit changes
soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
