ivankelly commented on a change in pull request #775: Tests wait for client to
see started bookie
URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153614842
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java
##########
@@ -558,26 +559,16 @@ public int startNewBookie()
protected BookieServer startBookie(ServerConfiguration conf)
throws Exception {
BookieServer server = new BookieServer(conf);
- server.start();
-
+ BookieSocketAddress address = Bookie.getBookieAddress(conf);
if (bkc == null) {
bkc = new BookKeeperTestClient(baseClientConf);
}
+ Future<?> waitForBookie = bkc.waitForBookie(address);
Review comment:
why? It doesn't use any completableFuture methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
