ArvinDevel commented on a change in pull request #832: Issue 620: Close the 
fileChannels for read when they are idle
URL: https://github.com/apache/bookkeeper/pull/832#discussion_r156560570
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
 ##########
 @@ -341,12 +346,43 @@ private int readFromLogChannel(long entryLogId, 
BufferedReadChannel channel, Byt
         }
     };
 
+    private final  CacheLoader<Long, FileChannel> loader = new 
CacheLoader<Long, FileChannel> () {
+        public FileChannel load(Long entryLogId) throws Exception {
 
 Review comment:
   @eolivelli  Just as @sijie said, can't use lambda due to it's an abstract 
class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to