eolivelli commented on a change in pull request #834: Issue 741: Switch to
Spotbugs
URL: https://github.com/apache/bookkeeper/pull/834#discussion_r156625527
##########
File path: pom.xml
##########
@@ -197,9 +197,9 @@
</extensions>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>findbugs-maven-plugin</artifactId>
- <version>${findbugs-maven-plugin.version}</version>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${spotbugs-maven-plugin.version}</version>
<configuration>
<excludeFilterFile>${session.executionRootDirectory}/buildtools/src/main/resources/bookkeeper/findbugsExclude.xml</excludeFilterFile>
Review comment:
@ivankelly there is already an issue, I have already sent emails in the past
months about this change.
I think we change keep findbugsExclude.xml as effectively SpotBugs is
Findbugs (it just changed owner) and internally the format of the file is the
same. The SportBugs maven plugin is a port of the Findbugs Maven plugin and all
the configs are the same.
But if you feel strong about this we can change it as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
