sijie commented on a change in pull request #838: Issue-326: Replace
observer/observable with a simplified watcher/watchable implementation
URL: https://github.com/apache/bookkeeper/pull/838#discussion_r156728184
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
##########
@@ -253,9 +249,11 @@ public long getLastAddConfirmed(long ledgerId) throws
IOException {
}
@Override
- public Observable waitForLastAddConfirmedUpdate(long ledgerId, long
previoisLAC, Observer observer)
+ public boolean waitForLastAddConfirmedUpdate(long ledgerId,
+ long previoisLAC,
+
Watcher<LastAddConfirmedUpdateNotification> watcher)
throws IOException {
- return ledgerCache.waitForLastAddConfirmedUpdate(ledgerId,
previoisLAC, observer);
+ return ledgerCache.waitForLastAddConfirmedUpdate(ledgerId,
previoisLAC, watcher);
Review comment:
will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
